Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to have DnsNameResolver.resolveAll(...) notify as soon as the pr… #9136

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
3 participants
@normanmaurer
Copy link
Member

commented May 8, 2019

…eferred records were resolved

Motivation:

075cf8c introduced a change to allow resolve(...) to notify as soon as the preferred record was resolved. This works great but we should also allow the user to configure that we want to do the same for resolveAll(...), which means we should be able to notify as soon as all records for a preferred record were resolved.

Modifications:

  • Add a new DnsNameResolverBuilder method to allow configure this (use false as default to not change default behaviour)
  • Add unit test

Result:

Be able to speed up resolving.

@normanmaurer normanmaurer requested a review from Scottmitch May 8, 2019

@normanmaurer

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

@ddossot FYI...

Allow to have DnsNameResolver.resolveAll(...) notify as soon as the p…
…referred records were resolved

Motivation:

075cf8c introduced a change to allow resolve(...) to notify as soon as the preferred record was resolved. This works great but we should also allow the user to configure that we want to do the same for resolveAll(...), which means we should be able to notify as soon as all records for a preferred record were resolved.

Modifications:

- Add a new DnsNameResolverBuilder method to allow configure this (use false as default to not change default behaviour)
- Add unit test

Result:

Be able to speed up resolving.

@normanmaurer normanmaurer force-pushed the resolve_all_preferred_fast branch from bb88d22 to 3a5d28d May 8, 2019

@normanmaurer normanmaurer changed the title Allow to have DnsNameResolve.resolveAll(...) notify as soon as the pr… Allow to have DnsNameResolver.resolveAll(...) notify as soon as the pr… May 8, 2019

@normanmaurer normanmaurer requested review from ejona86, trustin and njhill May 8, 2019

@normanmaurer

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

@netty-bot test this please

@normanmaurer normanmaurer added this to the 4.1.37.Final milestone May 8, 2019

@ejona86

ejona86 approved these changes May 8, 2019

@trustin

trustin approved these changes May 9, 2019

Copy link
Member

left a comment

Thanks, @normanmaurer

@normanmaurer normanmaurer self-assigned this May 9, 2019

@normanmaurer normanmaurer merged commit df20a12 into 4.1 May 9, 2019

3 checks passed

pull request validation (centos6-java11) Build finished.
Details
pull request validation (centos6-java12) Build finished.
Details
pull request validation (centos6-java8) Build finished.
Details

@normanmaurer normanmaurer deleted the resolve_all_preferred_fast branch May 9, 2019

normanmaurer added a commit that referenced this pull request May 9, 2019

Allow to have DnsNameResolver.resolveAll(...) notify as soon as the p…
…referred records were resolved (#9136)

Motivation:

075cf8c introduced a change to allow resolve(...) to notify as soon as the preferred record was resolved. This works great but we should also allow the user to configure that we want to do the same for resolveAll(...), which means we should be able to notify as soon as all records for a preferred record were resolved.

Modifications:

- Add a new DnsNameResolverBuilder method to allow configure this (use false as default to not change default behaviour)
- Add unit test

Result:

Be able to speed up resolving.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.