Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DnsNameResolver.resolveAll(DnsQuestion) should not try to filter dupl… #9141

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
2 participants
@normanmaurer
Copy link
Member

commented May 10, 2019

…icates

Motivation:

#9021 did apply some changes to filter out duplicates InetAddress when calling resolveAll(...) to mimic JDK behaviour. Unfortunally this also introduced a regression as we should not filter duplicates when the user explicit calls resolveAll(DnsQuestion).

Modifications:

  • Only filter duplicates if resolveAll(String) is used
  • Add unit test

Result:

Fixes regressions introduces by #9021

DnsNameResolver.resolveAll(DnsQuestion) should not try to filter dupl…
…icates

Motivation:

#9021 did apply some changes to filter out duplicates InetAddress when calling resolveAll(...) to mimic JDK behaviour. Unfortunally this also introduced a regression as we should not filter duplicates when the user explicit calls resolveAll(DnsQuestion).

Modifications:

- Only filter duplicates if resolveAll(String) is used
- Add unit test

Result:

Fixes regressions introduces by #9021

@normanmaurer normanmaurer requested a review from trustin May 10, 2019

@normanmaurer

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

Thanks @trustin for reporting

@trustin
Copy link
Member

left a comment

Thanks!

@normanmaurer normanmaurer merged commit 6ee8b65 into 4.1 May 13, 2019

3 checks passed

pull request validation (centos6-java11) Build finished.
Details
pull request validation (centos6-java12) Build finished.
Details
pull request validation (centos6-java8) Build finished.
Details

@normanmaurer normanmaurer deleted the resolve_all_duplicate branch May 13, 2019

normanmaurer added a commit that referenced this pull request May 13, 2019

DnsNameResolver.resolveAll(DnsQuestion) should not try to filter dupl…
…icates (#9141)

Motivation:

#9021 did apply some changes to filter out duplicates InetAddress when calling resolveAll(...) to mimic JDK behaviour. Unfortunally this also introduced a regression as we should not filter duplicates when the user explicit calls resolveAll(DnsQuestion).

Modifications:

- Only filter duplicates if resolveAll(String) is used
- Add unit test

Result:

Fixes regressions introduces by #9021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.