Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Try to mark child channel writable again once the parent channel beco… #9254
f945a07 decoupled the writability state from the flow controller but could lead to the situation of a lot of writability updates events were propagated to the child channels. This change ensure we only take into account if the parent channel becomes writable again before we try to set the child channels to writable.
Only listen for channel writability changes for if the parent channel becomes writable again.
Less writability updates.
ejona86 left a comment
Storing the channels waiting for the parent in an ArrayDeque or a linked list using pointers in each channel would be fine. But that can be done later as an optimization. I was mainly just wanting the behavior we expose to allow for an efficient implementation, not as much have that implementation now.