Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check to isSkippable. Fixes #9278 #9280

Merged
merged 1 commit into from Jun 25, 2019

Conversation

Projects
None yet
3 participants
@graemerocher
Copy link
Contributor

commented Jun 25, 2019

Motivation:

Currently GraalVM substrate returns null for reflective calls if the reflection access is not declared up front.

A change introduced in Netty 4.1.35 results in needing to register every Netty handler for reflection. This complicates matters as it is difficult to know all the possible handlers that need to be registered.

Modification:

This change adds a simple
null check such that Netty does not break on GraalVM substrate without the reflection information registration.

Result:

Fixes #9278

Add null check to isSkippable. Fixes #9278
Currently GraalVM substrate returns null for reflective calls if the reflection access is not declared up front.
A change introduced in Netty 4.1.35 results in needing to register every Netty handler for reflection. This complicates
matters as it is difficult to know all the possible handlers that need to be registered. This change adds a simple
null check such that Netty does not break on GraalVM substrate without the reflection information registration.
@netty-bot

This comment has been minimized.

Copy link

commented Jun 25, 2019

Can one of the admins verify this patch?

@normanmaurer

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

@graemerocher can you sign out ICLA ?

https://netty.io/s/icla

@graemerocher

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2019

Done

@normanmaurer

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

@netty-bot Test this please

@normanmaurer

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

@netty-bot test this please

@graemerocher

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2019

The test failures seem unrelated?

@normanmaurer

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

@graemerocher yeah...CI is a bit flaky today :/

@normanmaurer

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

@netty-bot test this please

@normanmaurer normanmaurer added this to the 4.1.37.Final milestone Jun 25, 2019

@normanmaurer normanmaurer merged commit 18b7bdf into netty:4.1 Jun 25, 2019

3 checks passed

pull request validation (centos6-java11) Build finished.
Details
pull request validation (centos6-java12) Build finished.
Details
pull request validation (centos6-java8) Build finished.
Details
@normanmaurer

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

@graemerocher thanks a lot!

normanmaurer added a commit that referenced this pull request Jun 25, 2019

Add null check to isSkippable. Fixes #9278 (#9280)
Motivation:

Currently GraalVM substrate returns null for reflective calls if the reflection access is not declared up front.

A change introduced in Netty 4.1.35 results in needing to register every Netty handler for reflection. This complicates matters as it is difficult to know all the possible handlers that need to be registered.

Modification:

This change adds a simple
null check such that Netty does not break on GraalVM substrate without the reflection information registration.

Result:

Fixes #9278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.