Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the ORIGIN header from a custom headers if present #9435

Merged

Conversation

@amizurov
Copy link
Contributor

commented Aug 7, 2019

Motivation:

Allow to set the ORIGIN header value from custom headers in WebSocketClientHandshaker

@netty-bot

This comment has been minimized.

Copy link

commented Aug 7, 2019

Can one of the admins verify this patch?

@normanmaurer

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

@netty-bot test this please

@normanmaurer normanmaurer added this to the 4.1.39.Final milestone Aug 11, 2019

@normanmaurer normanmaurer merged commit b8ac02d into netty:4.1 Aug 11, 2019

3 checks passed

pull request validation (centos6-java11) Build finished.
Details
pull request validation (centos6-java12) Build finished.
Details
pull request validation (centos6-java8) Build finished.
Details

normanmaurer added a commit that referenced this pull request Aug 11, 2019

Set the ORIGIN header from a custom headers if present (#9435)
Motivation:

Allow to set the ORIGIN header value from custom headers in WebSocketClientHandshaker

Modification:

Only override header if not present already

Result:

More flexible handshaker usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.