Reference-counted SslEngines retain a reference to their parent SslContext #9626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntext Motivation: With the Netty ref-counted OpenSSL implementation the parent SslContext maintains state necessary for the SslEngine's it produces. However, it's possible for the parent context to be closed and release those resources before the child engines are finished which causes problems. Modification: Spawned ReferenceCountedOpenSslEngine's retain a reference to their parent ReferenceCountedOpenSslContext. Result: The lifetime of the shared data is extended to include the lifetime of the dependents.
|
Can one of the admins verify this patch? |
vkostyukov
approved these changes
Sep 30, 2019
|
/cc @rkapsi |
|
Ping. Any more feedback on this? |
|
LGTM as well |
johnou
approved these changes
Oct 3, 2019
|
@netty-bot test this please |
|
@bryce-anderson good one! |
normanmaurer
pushed a commit
that referenced
this pull request
Oct 7, 2019
…ntext (#9626) Motivation: With the Netty ref-counted OpenSSL implementation the parent SslContext maintains state necessary for the SslEngine's it produces. However, it's possible for the parent context to be closed and release those resources before the child engines are finished which causes problems. Modification: Spawned ReferenceCountedOpenSslEngine's retain a reference to their parent ReferenceCountedOpenSslContext. Result: The lifetime of the shared data is extended to include the lifetime of the dependents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
With the Netty ref-counted OpenSSL implementation the parent SslContext
maintains state necessary for the SslEngine's it produces. However, it's
possible for the parent context to be closed and release those resources
before the child engines are finished which causes problems.
Modification:
Spawned ReferenceCountedOpenSslEngine's retain a reference to their
parent ReferenceCountedOpenSslContext.
Result:
The lifetime of the shared data is extended to include the lifetime of
the dependents.