Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #9667: FlowControllerHandler swallows read-complete event when auto-read is disabled #9691

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@ursaj
Copy link
Contributor

ursaj commented Oct 18, 2019

Modification:

  • Fire read-complete event from flow controller, when it previously was swallowed
  • New unit test to cover this case

Result:

Fixes #9667: FlowControllerHandler swallows read-complete event when auto-read is disabled

@netty-bot

This comment has been minimized.

Copy link

netty-bot commented Oct 18, 2019

Can one of the admins verify this patch?

Copy link
Member

normanmaurer left a comment

Please address and let me know once done

@normanmaurer normanmaurer requested a review from rkapsi Oct 19, 2019
@normanmaurer

This comment has been minimized.

Copy link
Member

normanmaurer commented Oct 19, 2019

@rkapsi Please take a look as well

@ursaj

This comment has been minimized.

Copy link
Contributor Author

ursaj commented Oct 20, 2019

@normanmaurer all review notes were fixed

@normanmaurer

This comment has been minimized.

Copy link
Member

normanmaurer commented Oct 22, 2019

@netty-bot test this please

Copy link
Member

normanmaurer left a comment

@ursaj great catch! One nit then ready to be merged

@normanmaurer normanmaurer added this to the 4.1.43.Final milestone Oct 22, 2019
… auto-read is disabled
@ursaj ursaj force-pushed the ursaj:bugfix-9667-flow-controller branch from 519f7e7 to a5d3936 Oct 22, 2019
@normanmaurer

This comment has been minimized.

Copy link
Member

normanmaurer commented Oct 23, 2019

@netty-bot test this please

@normanmaurer normanmaurer merged commit 73f5c83 into netty:4.1 Oct 23, 2019
3 checks passed
3 checks passed
pull request validation (centos6-java11) Build finished.
Details
pull request validation (centos6-java12) Build finished.
Details
pull request validation (centos6-java8) Build finished.
Details
@normanmaurer

This comment has been minimized.

Copy link
Member

normanmaurer commented Oct 23, 2019

@ursaj thanks a lot!

@ursaj ursaj deleted the ursaj:bugfix-9667-flow-controller branch Oct 23, 2019
normanmaurer added a commit that referenced this pull request Oct 23, 2019
… auto-read is disabled (#9691)

FlowControllerHandler currently may swell read-complete events in some situations.

* Fire read-complete event from flow controller, when it previously was swallowed
* New unit test to cover this case

Fixes #9667: FlowControllerHandler swallows read-complete event when auto-read is disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.