Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore invalid entries in /etc/resolv.conf when parsing #9697

Merged
merged 1 commit into from Oct 22, 2019

Conversation

@normanmaurer
Copy link
Member

normanmaurer commented Oct 21, 2019

Motivation:

We should just ignore (and so skip) invalid entries in /etc/resolver.conf.

Modifications:

  • Skip invalid entries
  • Add unit test

Result:

Fix #9684

Motivation:

We should just ignore (and so skip) invalid entries in /etc/resolver.conf.

Modifications:

- Skip invalid entries
- Add unit test

Result:

Fix #9684

After your change, what will change.
@normanmaurer normanmaurer requested a review from slandelle Oct 21, 2019
@normanmaurer

This comment has been minimized.

Copy link
Member Author

normanmaurer commented Oct 21, 2019

@slandelle PTAL again

@normanmaurer normanmaurer force-pushed the ignore_entry branch from 0b3223e to a07f953 Oct 21, 2019
@normanmaurer normanmaurer merged commit c7441f6 into 4.1 Oct 22, 2019
2 of 3 checks passed
2 of 3 checks passed
pull request validation (centos6-java11) Build finished.
Details
pull request validation (centos6-java12) Build finished.
Details
pull request validation (centos6-java8) Build finished.
Details
@normanmaurer normanmaurer deleted the ignore_entry branch Oct 22, 2019
normanmaurer added a commit that referenced this pull request Oct 22, 2019
Motivation:

We should just ignore (and so skip) invalid entries in /etc/resolver.conf.

Modifications:

- Skip invalid entries
- Add unit test

Result:

Fix #9684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.