Fixed optional comma separator in %strcat#25
Merged
hpax merged 1 commit intonetwide-assembler:masterfrom Nov 7, 2022
Merged
Conversation
Signed-off-by: "Glücksmann, Igor" <igor.glucksmann@avast.com>
Contributor
|
Didn't test but this should fix https://bugzilla.nasm.us/show_bug.cgi?id=3392732 that I reported in 2020 December. |
Contributor
Author
|
Ah, didn't see that. |
Contributor
|
Tested building this now merged with the latest git commit 3aebb20 and it works on two Debian Linux systems. |
Member
|
Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression in commit 20e0d61.
The comma now arrives as TOKEN_COMMA rather than TOKEN_OTHER - so the optional (as mentioned in the docs) comma separators in %strcat are not allowed.