output/elf: Don't set data symbol type/size in ABS sections #36
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm dealing with a FreeBSD-derived embedded target that ends up showing such symbols (which is mainly NASM struct definitions) in backtraces after calling NULL function pointers, since these symbols _are_ technically covering bytes around address zero. Needless to say, this is extremely confusing and generates nonsensical bug reports. (Essentially, random unrelated crashes get cross-referenced to a random ASM struct, whatever the linker picked for address 0). These symbols are already a bit strange to begin with (they're purely an artifact of how NASM happens to implement structs), leaving their sizes at 0 seems reasonable. Signed-off-by: Fabian Giesen <fabian.giesen@epicgames.com>
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I'm dealing with a FreeBSD-derived embedded target that ends up
showing such symbols (which is mainly NASM struct definitions)
in backtraces after calling NULL function pointers, since these
symbols are technically covering bytes around address zero.
Needless to say, this is extremely confusing and generates
nonsensical bug reports. (Essentially, random unrelated crashes
get cross-referenced to a random ASM struct, whatever the linker
picked for address 0).
These symbols are already a bit strange to begin with (they're
purely an artifact of how NASM happens to implement structs),
leaving their sizes at 0 seems reasonable.
Signed-off-by: Fabian Giesen fabian.giesen@epicgames.com