Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #607 Collect Status and StackTrace on Error in light-4j handlers #608

Merged
merged 3 commits into from Aug 28, 2019

Conversation

@ddobrin
Copy link
Contributor

ddobrin commented Aug 27, 2019

No description provided.

…s for auditing purposes
@ddobrin ddobrin requested review from stevehu, chenyan71 and yibogithub Aug 27, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #608 into 1.6.x will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##              1.6.x     #608      +/-   ##
============================================
- Coverage     51.15%   51.15%   -0.01%     
- Complexity     1899     1905       +6     
============================================
  Files           258      258              
  Lines         11370    11386      +16     
  Branches       1610     1615       +5     
============================================
+ Hits           5816     5824       +8     
- Misses         4872     4880       +8     
  Partials        682      682
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/networknt/utility/Constants.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rc/main/java/com/networknt/audit/AuditHandler.java 51.72% <100%> (-0.82%) 11 <4> (ø)
...ain/java/com/networknt/metrics/MetricsHandler.java 31.34% <100%> (ø) 5 <1> (ø) ⬇️
...va/com/networknt/handler/config/HandlerConfig.java 95.45% <100%> (+1.7%) 14 <4> (+4) ⬆️
...etworknt/metrics/prometheus/PrometheusHandler.java 38.63% <100%> (ø) 5 <1> (ø) ⬇️
...n/java/com/networknt/handler/LightHttpHandler.java 6.89% <9.09%> (+1.34%) 1 <0> (ø) ⬇️
...n/java/com/networknt/client/oauth/OauthHelper.java 37.04% <0%> (+0.6%) 28% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f6ce33...543be7a. Read the comment docs.

handler/pom.xml Outdated Show resolved Hide resolved
@stevehu stevehu merged commit 1a9d136 into 1.6.x Aug 28, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@stevehu stevehu deleted the issue/607 branch Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.