Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- fixed #839 Error status resulted at framework middleware handler is… #842

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

jiachen1120
Copy link
Contributor

issue: #839

… missing in auditInfo

- Added unit test
@codecov-io
Copy link

Codecov Report

Merging #842 (410778b) into 1.6.x (019bcc6) will increase coverage by 0.13%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              1.6.x     #842      +/-   ##
============================================
+ Coverage     48.83%   48.96%   +0.13%     
- Complexity     1935     1941       +6     
============================================
  Files           267      267              
  Lines         12080    12081       +1     
  Branches       1692     1692              
============================================
+ Hits           5899     5916      +17     
+ Misses         5479     5462      -17     
- Partials        702      703       +1     
Impacted Files Coverage Δ Complexity Δ
...n/java/com/networknt/handler/LightHttpHandler.java 8.33% <0.00%> (ø) 1.00 <0.00> (ø)
...rc/main/java/com/networknt/audit/AuditHandler.java 59.32% <100.00%> (+7.59%) 13.00 <0.00> (+2.00)
...n/java/com/networknt/client/oauth/OauthHelper.java 35.96% <0.00%> (+0.58%) 28.00% <0.00%> (+2.00%)
...ver/src/main/java/com/networknt/server/Server.java 35.51% <0.00%> (+4.08%) 17.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019bcc6...410778b. Read the comment docs.

@stevehu stevehu merged commit b9033a3 into 1.6.x Nov 30, 2020
@stevehu stevehu deleted the fix/#839_error_status_missing_in_auditInfo branch November 30, 2020 22:43
stevehu pushed a commit that referenced this pull request Nov 30, 2020
#842)

* - fixed #839 Error status resulted at framework middleware handler is missing in auditInfo
- Added unit test

* - #839 revert unnecessary changes
younggwon1 pushed a commit to younggwon1/light-4j that referenced this pull request Feb 10, 2024
…andler is… (networknt#842)

* - fixed networknt#839 Error status resulted at framework middleware handler is missing in auditInfo
- Added unit test

* - networknt#839 revert unnecessary changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants