Fix/861 config load exception when auditing service id #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2020 23:42
…ix/861-audit-serviceId
|
@BalloonWen Thanks for the quick fix!! Do you think it would be better to load the configuration when class initialize to prevent load server config for every requests? for example load when construct audithandler? public AuditHandler() {
if (logger.isInfoEnabled()) logger.info("AuditHandler is loaded.");
auditConfig = AuditConfig.load();
serverConfig = // load no cache config here?
} |
|
@jiachen1120 I think that is a good idea as we are not using cache anymore. In the Http2Client, I am loading the server.yml in a static block. |
|
@jiachen1120 good idea, @stevehu will do in this PR |
stevehu
pushed a commit
that referenced
this pull request
Dec 11, 2020
* issue-861 - fixed issue when getting server config in AuditHandler by using getJsonMapConfigNoCache * issue-861 - to avoid getting config per request, will get the service id when constructing the class Co-authored-by: Bolun Wen <bolun.wen@sunlife.com>
BalloonWen
changed the title
younggwon1
pushed a commit
to younggwon1/light-4j
that referenced
this pull request
Feb 10, 2024
* issue-861 - fixed issue when getting server config in AuditHandler by using getJsonMapConfigNoCache * issue-861 - to avoid getting config per request, will get the service id when constructing the class Co-authored-by: Bolun Wen <bolun.wen@sunlife.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issue when getJsonMapConfig