Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Exectution Strategies #47

Merged

Conversation

Projects
None yet
2 participants
@logi
Copy link
Contributor

commented Aug 23, 2018

Make it possible to override the 3 execution strategies used by GraphQL for Queries, Mutations and Subscriptions respectively in case the defaults are not suitable.

@NicholasAzar NicholasAzar self-requested a review Aug 24, 2018


// Replace default execution strategies if so configured.
ExecutionStrategyProvider executionStrategyProvider = SingletonServiceFactory.getBean(ExecutionStrategyProvider.class);
if(executionStrategyProvider != null) {

This comment has been minimized.

Copy link
@NicholasAzar

NicholasAzar Aug 24, 2018

Member

In the three condition checks, i think you meant to include an additional condition for the result of the get methods, right? Otherwise it would be weird to check the same condition 3 separate times..

This comment has been minimized.

Copy link
@logi

logi Aug 24, 2018

Author Contributor

Uh, yes. This is straight up broken bad code. Let me redo it.

This comment has been minimized.

Copy link
@logi

logi Aug 24, 2018

Author Contributor

Actually, the check for the results is further down where they are either passed to the GraphQL.Builder or not. But this is clearly pointless repetition anyway.

@NicholasAzar
Copy link
Member

left a comment

Looks good! Thanks @logi

@NicholasAzar NicholasAzar merged commit a86e2cb into networknt:develop Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.