Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial GraphqlEndpointSource listing `/graphql@{get,post,options}`… #49

Merged
merged 2 commits into from Sep 12, 2018

Conversation

Projects
None yet
3 participants
@logi
Copy link
Contributor

commented Sep 12, 2018

… endpoints as configured in graphql.yml to match what the GraphqlRouter will set up.

Usage:

paths:

# Standard GraphQL End-Points

- source: com.networknt.graphql.router.GraphqlEndpointSource
  exec:
  - common-chain
  - graphql-verify
  - audit
  - graphql-validator
  - graphql-handler

The following gets logged at startup (with default graphql.yml):

10:21:38.644 [main] is.thing.usernotes.0.0  INFO  com.networknt.config.Config getConfigStream - Config loaded from default folder for graphql.yml
10:21:38.649 [main] is.thing.usernotes.0.0  INFO  c.n.g.router.GraphqlEndpointSource listEndpoints - Generating /graphql from graphql.yml
Trivial GraphqlEndpointSource listing the `/graphql@{get,post,options…
…}` endpoints as configured in `graphql.yml` to match what the `GraphqlRouter` will set up.

Usage:
```yaml
paths:

# Standard GraphQL End-Points

- source: com.networknt.graphql.router.GraphqlEndpointSource
  exec:
  - common-chain
  - graphql-verify
  - audit
  - graphql-validator
  - graphql-handler
```

The following gets logged at startup (with default `graphql.yml`):
```
10:21:38.644 [main] is.thing.usernotes.0.0  INFO  com.networknt.config.Config getConfigStream - Config loaded from default folder for graphql.yml
10:21:38.649 [main] is.thing.usernotes.0.0  INFO  c.n.g.router.GraphqlEndpointSource listEndpoints - Generating /graphql from graphql.yml
```

@stevehu stevehu requested review from stevehu and NicholasAzar Sep 12, 2018


/**
* Lists standard GraphQl endpoints at /graphql and /subscriptions.
*/

This comment has been minimized.

Copy link
@NicholasAzar

NicholasAzar Sep 12, 2018

Member

Would you mind updating this comment since the one bellow it states that /subscriptions doesn't need to be listed?

This comment has been minimized.

Copy link
@logi

logi Sep 12, 2018

Author Contributor

Ah, yes. That's from before I realised that the websocket handling bypasses the paths completely.

@stevehu stevehu merged commit 4f807bd into networknt:develop Sep 12, 2018

@stevehu

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2018

@logi @NicholasAzar Thanks for the great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.