New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbedtls/net.h is deprecated. Use mbedtls/net_sockets.h instead. #110

Merged
merged 2 commits into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@drichardson
Contributor

drichardson commented Nov 14, 2018

As of mbedtls version 2.4.2 (though perhaps earlier as well) mbedtls/net.h is deprecated.

Changing yojimbo to use mbedtls/net_sockets.h instead, per deprecation message.

@drichardson

This comment has been minimized.

Contributor

drichardson commented Nov 14, 2018

Looks like the version of mbedtls on the Travis server does not have the new header file, mbedtls/net_sockets.h.

I also noticed that docker/Dockerfile references an older version of mbedtls as well.

mbedtls/net.h is deprecated. Use mbedtls/net_sockets.h instead.
Use mbedtls 2.13.0 in Travis build.

@drichardson drichardson force-pushed the drichardson:fix-mbedtls-deprecation-warning branch from 94ab1e3 to d9f1e2f Nov 14, 2018

@drichardson

This comment has been minimized.

Contributor

drichardson commented Nov 14, 2018

I still need to test the docker build.

@gafferongames

This comment has been minimized.

Member

gafferongames commented Nov 14, 2018

Yes, would be great if we can update the docker container in travis the newer version of mbedtls, then I can accept this pull request... I think there is a .travis.yaml or something in root that controls this?

@drichardson

This comment has been minimized.

Contributor

drichardson commented Nov 14, 2018

Updated docker/Dockerfile to mbedtls-2.13.0 and also updated the Docker base image to phusion 0.11, the latest released version.

@drichardson

This comment has been minimized.

Contributor

drichardson commented Nov 14, 2018

I was able to run the docker image and connect to it using test/client.

@gafferongames

This comment has been minimized.

Member

gafferongames commented Nov 14, 2018

Cool. Thanks!

@gafferongames gafferongames merged commit b3555f5 into networkprotocol:master Nov 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@drichardson drichardson deleted the drichardson:fix-mbedtls-deprecation-warning branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment