New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several of the premake5 commands that relied on os.execute. #113

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@drichardson
Contributor

drichardson commented Nov 15, 2018

As of Lua 5.2, os.execute returns 3-tuple. In 5.1 and before it returned the status code. This change updates premake5.lua to use the Lua 5.2 definition of os.execute.

premake5 5.0.0 alpha 13 is using Lua 5.3.4.

Fix several of the premake5 commands that relied on os.execute.
As of Lua 5.2, os.execute returns 3-tuple. In 5.1 and before it returned
the status code.

@gafferongames gafferongames merged commit 01e0a0b into networkprotocol:master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@drichardson drichardson deleted the drichardson:fix-execute-commands branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment