This repository was archived by the owner on Oct 29, 2021. It is now read-only.
Add shellcheck support and rework integration tests #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you double check patch? Looks like many patches were added that were not meant to be a part of this merge. |
fkautz
suggested changes
Jul 6, 2018
Member
fkautz
left a comment
fkautz
left a comment
There was a problem hiding this comment.
GH won't let me leave a review without a comment. Sot this comment is a repeat. Check the commits on this, looks like more may of ended up in this patch than was expected.
Break the integration tests up so they can more easily be run from a developer's own Kubernetes install. Signed-off-by: Kyle Mestery <mestery@mestery.com>
Signed-off-by: Kyle Mestery <mestery@mestery.com>
Signed-off-by: Kyle Mestery <mestery@mestery.com>
Signed-off-by: Kyle Mestery <mestery@mestery.com>
This commit adds shellcheck into the CI system. Shellcheck will verify our shell scripts are compliant with it's static analysis checking, saving us immense debugging efforts. Yay! Signed-off-by: Kyle Mestery <mestery@mestery.com>
Collaborator
Author
|
@fkautz Done, cleaned this up! |
fkautz
approved these changes
Jul 8, 2018
doonhammer
pushed a commit
to doonhammer/networkservicemesh
that referenced
this pull request
Aug 8, 2018
…sh#141) * Cleanup the integration tests Break the integration tests up so they can more easily be run from a developer's own Kubernetes install. * Run the travis integration tests in travis * Add a script for developers to run integration tests * Rename integration-tests-helpers.sh to integration-test-helpers.sh * Add shellcheck support This commit adds shellcheck into the CI system. Shellcheck will verify our shell scripts are compliant with it's static analysis checking, saving us immense debugging efforts. Yay!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139
Closes #140
This PR does a few things:
To run the CI scripts by hand against an existing Kubernetes install:
./scripts/dev-integration-tests.shThis requires the Docker images for both the server and client to built, but the tests will verify this and point you towards this if they do not exist.
[1] https://github.com/koalaman/shellcheck