Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated LLDP Neighbor Detail for matching on some devices that were missing. #372

Merged
merged 9 commits into from Feb 23, 2019

Conversation

Projects
None yet
3 participants
@jvanderaa
Copy link
Contributor

jvanderaa commented Feb 19, 2019

ISSUE TYPE
  • Bugfix Pull Request
  • Additional Testing
COMPONENT

cisco_ios_show_lldp_neighbors_detail.template

SUMMARY
  • After working with @itdependsnetworks we changed the neighbor setup.
  • Created raw file with the information to test against what was failing previous

Before

{"msg": "State Error raised. Rule Line: 47. Input Line: System Name: ZULTYS IP Phone"}

After

        {
            "CAPABILITIES": "T",
            "CHASSIS_ID": "172.16.4.125",
            "LOCAL_INTERFACE": "Gi2/0/13",
            "MANAGEMENT_IP": "",
            "NEIGHBOR": "ZULTYS IP Phone",
            "NEIGHBOR_INTERFACE": "WAN PORT",
            "NEIGHBOR_PORT_ID": "000b.ea00.96e0",
            "SYSTEM_DESCRIPTION": "ZULTYS IP Phone",
            "VLAN": ""
        },

jvanderaa and others added some commits Feb 18, 2019

Update cisco_ios_show_lldp_neighbors_detail.template
Updated to match that which was tested for catching all neighbors. This is to update to take care of the 4th raw parsing.

Previously:
`System Name: ZULTYS IP Phone` is not matching   `^System\s+Name(?::\s+${NEIGHBOR}|\s+-\s+not\s+advertised)\s*$$`
Josh VanDeraa
@itdependsnetworks

This comment has been minimized.

Copy link
Contributor

itdependsnetworks commented Feb 19, 2019

Can you provide a full output? Not having the headers and footers (total entries) can make it lose context in the future. I realize not all of these have it, but would like to set a better precedence moving forward.

Josh VanDeraa added some commits Feb 20, 2019

Josh VanDeraa
Added header/footer content, fixed subsequent error on the template e…
…ngine with single entry LLDP output including Header/footer
Josh VanDeraa
Added header/footer content, fixed subsequent error on the template e…
…ngine with single entry LLDP output including Header/footer
@jvanderaa

This comment has been minimized.

Copy link
Contributor Author

jvanderaa commented Feb 22, 2019

I need to delete commit e62f049 from this. Working on figuring out the proper way to do that since I didn't branch properly on the fork.

jmcgill298 and others added some commits Feb 23, 2019

Update templates/cisco_ios_show_lldp_neighbors_detail.template
Co-Authored-By: jvanderaa <joshvanderaa@gmail.com>
Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…
…_neighbors_detail4.raw

Co-Authored-By: jvanderaa <joshvanderaa@gmail.com>

@jmcgill298 jmcgill298 merged commit 20e3809 into networktocode:master Feb 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.