From 17fff8758065b4a864ef33e2e7a0eb05e96e3d5e Mon Sep 17 00:00:00 2001 From: Stephen Kiely Date: Thu, 30 Apr 2026 11:32:10 -0500 Subject: [PATCH 1/3] Prepatch bump --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 07ba526f..d684605f 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [tool.poetry] name = "pyntc" -version = "2.4.0" +version = "2.4.1a0" description = "Python library focused on tasks related to device level and OS management." authors = ["Network to Code, LLC "] readme = "README.md" From bf48763e50da992c53624dde3e0ea6bd5dcf9d6b Mon Sep 17 00:00:00 2001 From: Gary Snider <75227981+gsnider2195@users.noreply.github.com> Date: Fri, 1 May 2026 12:28:46 -0700 Subject: [PATCH 2/3] fix nxos install_os not exiting early if a reboot was not requested. (#380) * fix nxos install_os not exiting early if a reboot was not requested. * changelog --- changes/380.fixed | 1 + pyntc/devices/nxos_device.py | 3 +++ 2 files changed, 4 insertions(+) create mode 100644 changes/380.fixed diff --git a/changes/380.fixed b/changes/380.fixed new file mode 100644 index 00000000..d28c4b3f --- /dev/null +++ b/changes/380.fixed @@ -0,0 +1 @@ +Fixed nxos install_os waiting for the device to reboot even if a reboot was not requested. diff --git a/pyntc/devices/nxos_device.py b/pyntc/devices/nxos_device.py index c0e24eac..8a453beb 100644 --- a/pyntc/devices/nxos_device.py +++ b/pyntc/devices/nxos_device.py @@ -637,6 +637,9 @@ def install_os(self, image_name, reboot=True, **vendor_specifics): if not self._image_booted(image_name): log.info("Host %s: Setting Image %s in boot options.", self.host, image_name) self.set_boot_options(image_name, reboot=reboot, **vendor_specifics) + if not reboot: + log.info("Host %s: OS image %s boot options set. Reboot the device to apply", self.host, image_name) + return True log.info("Host %s: Waiting for device reload.", self.host) self._wait_for_device_reboot(timeout=timeout) if not self._image_booted(image_name): From d6bd94aea196722eac4ad97c72e2da5d164ff34a Mon Sep 17 00:00:00 2001 From: Gary Snider <75227981+gsnider2195@users.noreply.github.com> Date: Fri, 1 May 2026 12:40:26 -0700 Subject: [PATCH 3/3] release v2.4.1 --- changes/380.fixed | 1 - docs/admin/release_notes/version_2.4.md | 7 +++++++ poetry.lock | 2 +- pyproject.toml | 4 ++-- 4 files changed, 10 insertions(+), 4 deletions(-) delete mode 100644 changes/380.fixed diff --git a/changes/380.fixed b/changes/380.fixed deleted file mode 100644 index d28c4b3f..00000000 --- a/changes/380.fixed +++ /dev/null @@ -1 +0,0 @@ -Fixed nxos install_os waiting for the device to reboot even if a reboot was not requested. diff --git a/docs/admin/release_notes/version_2.4.md b/docs/admin/release_notes/version_2.4.md index 26c86309..d23ea1b0 100644 --- a/docs/admin/release_notes/version_2.4.md +++ b/docs/admin/release_notes/version_2.4.md @@ -8,6 +8,13 @@ This document describes all new features and changes in the release. The format - Add ability to check for sufficient free space before copying files to devices, with support for EOS, IOS, ASA, and JunOS platforms. - Added reboot flag to Device.install_os for supported platforms. + +## [v2.4.1 (2026-05-01)](https://github.com/networktocode/pyntc/releases/tag/v2.4.1) + +### Fixed + +- [#380](https://github.com/networktocode/pyntc/issues/380) - Fixed nxos install_os waiting for the device to reboot even if a reboot was not requested. + ## [v2.4.0 (2026-04-29)](https://github.com/networktocode/pyntc/releases/tag/v2.4.0) ### Added diff --git a/poetry.lock b/poetry.lock index 289a0b89..b2ba1c43 100644 --- a/poetry.lock +++ b/poetry.lock @@ -2229,7 +2229,7 @@ jinja2 = "*" tomli = {version = "*", markers = "python_version < \"3.11\""} [package.extras] -dev = ["furo (>=2024.05.06)", "nox", "packaging", "sphinx (>=5)", "twisted"] +dev = ["furo (>=2024.5.6)", "nox", "packaging", "sphinx (>=5)", "twisted"] [[package]] name = "transitions" diff --git a/pyproject.toml b/pyproject.toml index d684605f..6abcbece 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [tool.poetry] name = "pyntc" -version = "2.4.1a0" +version = "2.4.1" description = "Python library focused on tasks related to device level and OS management." authors = ["Network to Code, LLC "] readme = "README.md" @@ -172,7 +172,7 @@ addopts = "-vv --doctest-modules -p no:warnings --ignore-glob='*mock*'" [tool.towncrier] package = "pyntc" directory = "changes" -filename = "docs/admin/release_notes/version_2.3.md" +filename = "docs/admin/release_notes/version_2.4.md" template = "towncrier_template.j2" start_string = "" issue_format = "[#{issue}](https://github.com/networktocode/pyntc/issues/{issue})"