Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate scipy sparse matrix conversion functions #5262

Merged
merged 3 commits into from Jan 26, 2022

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Jan 15, 2022

The scipy.sparse array alternatives that supersede to_scipy_sparse_matrix and from_scipy_sparse_matrix are added in #5139. This is a follow-on PR to deprecate to/from_scipy_sparse_matrix.

Note this depends on #5139, so the history & diffs are a mess - marking as draft for now; I will clean up the history after #5139 is in.

@jarrodmillman
Copy link
Member

jarrodmillman commented Jan 23, 2022

@rossbar Is it possible to rebase this on master instead of merging? When we merged 5dfd57a, it included 10 contributors and a messy commit message. It is hard to review this PR b/c it includes stuff that is already merged.

@rossbar rossbar force-pushed the deprecate-scipy-matrix-conv-funcs branch from 86d25ab to b813187 Compare January 24, 2022 04:01
@rossbar rossbar marked this pull request as ready for review January 24, 2022 04:05
@MridulS MridulS merged commit d396995 into networkx:main Jan 26, 2022
@jarrodmillman jarrodmillman added this to the networkx-2.7 milestone Feb 2, 2022
MridulS pushed a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
* Switch to DeprecationWarning.

* Add tests and docs for scipy_sparse_matrix deps.

* Update release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants