Make chordal_graph_cliques a generator #5758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarrodmillman
approved these changes
Jun 16, 2022
rossbar
approved these changes
Jun 16, 2022
Comment on lines
+205
to
+207
| >>> cliques = [c for c in chordal_graph_cliques(G)] | ||
| >>> cliques[0] | ||
| frozenset({1, 2, 3}) |
There was a problem hiding this comment.
I think this is okay because, though the ordering of the cliques is arbitrary, it should be consistent between function calls. If we wanted to be extra sure though, we could use sorted to guarantee the ordering, e.g.
Suggested change
| >>> cliques = [c for c in chordal_graph_cliques(G)] | |
| >>> cliques[0] | |
| frozenset({1, 2, 3}) | |
| >>> cliques = sorted(chordal_graph_cliques(G)) | |
| [frozenset({1, 2, 3}), | |
| frozenset({2, 3, 4}), | |
| frozenset({3, 4, 5, 6}), | |
| frozenset({7, 8}), | |
| frozenset({9})] |
There was a problem hiding this comment.
This comment isn't a blocker though, we can always fix this up in a follow-up PR!
rossbar
force-pushed
the
make-chordal-graph-cliques-generator
branch
from
e4e2928
to
f20c854
Compare
MridulS
pushed a commit
to MridulS/networkx
that referenced
this pull request
Feb 4, 2023
Make chordal_graph_cliques a generator Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
Make chordal_graph_cliques a generator Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.