many commands and some helpers did use the currently most generic Exception possible: Exception. this is bad style as it would only allow to catch all exceptions. in many of the cases the exceptions are technically RuntimeExceptions and so have been replaced by these.
In b5c7137 the customer:delete command was introducted. It made use of an Dialog helper that had the getQuestion() method. The current Dialog helper does not have such a method any longer. Now the Dialog helper is: Symfony\Component\Console\Helper\DialogHelper which is deprecated. Fix is to not call that method any longer. Instead a private helper method is called which returns the string of the question. Closes #643 Closes #642
Non-explainables aren't good for reseaoning, so the "don't know why" skippings have been removed and we tried to find out what the concrete reasons are. As the tests did run but only not for 1.9.x versions, the skip is only done for these versions. Also a comment has been left there in case the (assumed) flaw has been fixed, the skip will be removed as well. Both tests of that testcase are skipped as both tests are affected by that problem. For the version check Magento 1 CE and EE is taken into account.
In 5000bb1 require_once has been shielded. That shield still did leak $this when used with PHP versions 5.4 or higher. This has been fixed by extracting the require process into a function of its own and unbinding $this with PHP 5.4 and higher. Additionally the single used variable has been replaced with anonymous function parameter reading via func_get_arg().
Summary: Empty return on internal getArgumentMessage() method. The method getArgumentMessage() did return an empty string when the optional message parameter was not given. The flaw has been introduced in ca97317 This has been fixed by putting input parameter processing on the top of the method and fixing the wrong sprintf() call.