Grammar correction and send warning to stderr #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2013 10:45
This warning, while useful in interactive usage, complicates things in
script. Errors/warnings belong in stderr, especially if a command can
finish it's task succefully.
This fix was prompted by using n98 in a cron script, like so:
#!/bin/sh
# ...
prefix=`n98-magerun.phar db:info prefix`
n98-magerun.phar db:query "TRUNCATE ${prefix}core_url_rewrites;"
# ...
This generated an SQL syntax error.
TODO:
- There may be more cases where warnings should be moved to stderr.
- Investigate if the formatter can be extended to automatically route
<error> tag to OutputInterface::getErrorOutput() for a better fix.
cmuench
added a commit
that referenced
this pull request
Dec 6, 2013
Grammar correction and send warning to stderr
steverobbins
pushed a commit
to steverobbins/n98-magerun
that referenced
this pull request
Apr 7, 2015
Grammar correction and send warning to stderr
steverobbins
pushed a commit
to steverobbins/n98-magerun
that referenced
this pull request
Apr 7, 2015
Grammar correction and send warning to stderr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit messages should explain it all. In short: