loadXML must be called AFTER preserveWhiteSpace #296

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

riker09 commented Jan 29, 2014

I created a very simple test case and could confirm this for PHP 5.3.10-1ubuntu3.9. If I load the XML _before_ calling $dom->preserveWhiteSpace = false; the passed XML will remain unchanged. If I load the XML _after_ setting the value everything works as expected. This might be related to issue #3.

@riker09 riker09 loadXML must be called *AFTER* preserveWhiteSpace
I created a very simple test case and could confirm this for PHP 5.3.10-1ubuntu3.9. If I load the XML *before* calling `$dom->preserveWhiteSpace = false;` the passed XML will remain unchanged. If I load the XML *after* setting the value everything works as expected. This might be related to issue #3.
c9e9e09
Owner

cmuench commented Jan 29, 2014

thanks. I will check this at the weekend.

@cmuench cmuench added a commit that referenced this pull request Feb 1, 2014

@cmuench cmuench [TASK] Manually merged pull request #296 - loadXML must be called AFT…
…ER preserveWhiteSpace
2354ce6
Owner

cmuench commented Feb 1, 2014

Thanks. I merged it to develop branch.

cmuench closed this Feb 1, 2014

@steverobbins steverobbins pushed a commit to steverobbins/n98-magerun that referenced this pull request Apr 7, 2015

@cmuench cmuench [TASK] Manually merged pull request #296 - loadXML must be called AFT…
…ER preserveWhiteSpace
671611f

@steverobbins steverobbins pushed a commit to steverobbins/n98-magerun that referenced this pull request Apr 7, 2015

@cmuench cmuench [TASK] Manually merged pull request #296 - loadXML must be called AFT…
…ER preserveWhiteSpace
ca226db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment