PHP 7.1 support #256

Open
ktomk opened this Issue Dec 4, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@ktomk
Contributor

ktomk commented Dec 4, 2016

Since 1 Dec 2016 PHP 7.1 stable has hit earth surface. Support for that version of the language is most likely to be requested therefore Magerun 2 should support it.

  • Lint Magerun 2 code with PHP 7.1
  • Run PHP-CS-Fixer with PHP 7.1 on Magerun 2 code
  • Build Magerun 2 with PHP 7.1
  • Run the Phpunit test-suite (w/o Magento 2 installation) with PHP 7.1
  • Install Magento 2 running Magerun 2 with PHP 7.1
  • Run the Phpunit test-suite (on the Magento 2 installation) with PHP 7.1

ktomk added a commit that referenced this issue Dec 4, 2016

Build with PHP 7.1 for some jobs, tasks #256
Changes in preparation of use on system with PHP 7.1:

- Add PHP 7.1 lint check
- Add PHP 7.1 code-style fixer check
- Add PHP 7.1 phar build

Running the Magento 2 install with PHP 7.1 is not yet possible as it
fails. Officially Magento 2 is not yet compabitle with PHP 7.1 but
it also does not work due to the fact that Magento 2 uses the outdated
mcrypt library for "security" and we see deprecation notices in the
testsuite everywhere. Symfony has support for these migrations with
the PhpUnit Bundle which might be a place to look into.

Refs:

- #256

@ktomk ktomk referenced this issue in magento/magento2 Dec 4, 2016

Open

Several Cryptography Flaws in Magento 2 #5701

ktomk added a commit to ktomk/n98-magerun that referenced this issue Dec 4, 2016

Build with PHP 7.1 for some jobs (WIP)
Applying changes similar as with Magerun 2 for PHP 7.1 forward
compatibility with our own code-base.

Changes can not be applied 1:1 as the build system is a bit different for
Magento 1 on Travis than with Magento 2.

Refs:

- netz98/n98-magerun2#256

ktomk added a commit to netz98/n98-magerun that referenced this issue Dec 4, 2016

Build with PHP 7.1 for some jobs
Applying changes similar as with Magerun 2 for PHP 7.1 forward
compatibility with our own code-base.

Changes can not be applied 1:1 as the build system is a bit different for
Magento 1 on Travis than for Magento 2.

Refs:

- netz98/n98-magerun2#256
@tkn98

This comment has been minimized.

Show comment
Hide comment
@tkn98

tkn98 Dec 6, 2016

Contributor

Another build task could be to run the Phpunit test-suite w/o installing Magento (would be unit-tests only, integration tests are skipped when no Magento application is found). Then Magerun code is better tested forward compatible.

Contributor

tkn98 commented Dec 6, 2016

Another build task could be to run the Phpunit test-suite w/o installing Magento (would be unit-tests only, integration tests are skipped when no Magento application is found). Then Magerun code is better tested forward compatible.

ktomk added a commit to ktomk/n98-magerun2 that referenced this issue Jan 23, 2017

Remove leftover cruft
Fixup of f30bfd8, slipped through from some local PHP 7.1 testing.

Refs:

- f30bfd8

- #256

ktomk added a commit that referenced this issue Jan 23, 2017

Remove leftover cruft
Fixup of f30bfd8, slipped through from some local PHP 7.1 testing.

Refs:

- f30bfd8

- #256

diazwatson added a commit to diazwatson/n98-magerun that referenced this issue Mar 15, 2017

Build with PHP 7.1 for some jobs
Applying changes similar as with Magerun 2 for PHP 7.1 forward
compatibility with our own code-base.

Changes can not be applied 1:1 as the build system is a bit different for
Magento 1 on Travis than for Magento 2.

Refs:

- netz98/n98-magerun2#256

cmuench added a commit to cmuench/n98-magerun2 that referenced this issue Oct 11, 2017

Build with PHP 7.1 for some jobs, tasks #256
Changes in preparation of use on system with PHP 7.1:

- Add PHP 7.1 lint check
- Add PHP 7.1 code-style fixer check
- Add PHP 7.1 phar build

Running the Magento 2 install with PHP 7.1 is not yet possible as it
fails. Officially Magento 2 is not yet compabitle with PHP 7.1 but
it also does not work due to the fact that Magento 2 uses the outdated
mcrypt library for "security" and we see deprecation notices in the
testsuite everywhere. Symfony has support for these migrations with
the PhpUnit Bundle which might be a place to look into.

Refs:

- netz98#256

cmuench added a commit to cmuench/n98-magerun2 that referenced this issue Oct 11, 2017

Remove leftover cruft
Fixup of f30bfd8, slipped through from some local PHP 7.1 testing.

Refs:

- f30bfd8

- #256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment