cache:flush command do not dispatch the `adminhtml_cache_flush_all` event #263

Closed
viktorsteinwand opened this Issue Dec 28, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@viktorsteinwand

viktorsteinwand commented Dec 28, 2016

If performing the cache:flush command, the expectation is, that the event like adminhtml_cache_flush_all or something similar will be dispatched. See https://github.com/netz98/n98-magerun2/blob/master/src/N98/Magento/Command/Cache/FlushCommand.php#L23

Please observe also the original Magento 2 cache flush command source: https://github.com/magento/magento2/blob/develop/app/code/Magento/Backend/Console/Command/CacheFlushCommand.php#L32

Thanks

ktomk added a commit that referenced this issue Jan 1, 2017

Dispatch adminhtml_cache_flush_all with cache:flush, closes #263
Thanks to Viktor Steinwand for reporting the missing event dispatch.

Refs:

- #263

- Command: cache:flush
@viktorsteinwand

This comment has been minimized.

Show comment
Hide comment
@viktorsteinwand

viktorsteinwand Jan 2, 2017

Thanks Tom Klingenberg!

Thanks Tom Klingenberg!

@tkn98 tkn98 added the enhancement label Jan 2, 2017

@tkn98

This comment has been minimized.

Show comment
Hide comment
@tkn98

tkn98 Jan 2, 2017

Contributor

Thank you for the report! Let us know in case this does not work as intended:

We believe that the bug reported is fixed in the development version. It can be upgraded to it using the self-update command with the --unstable switch.

Contributor

tkn98 commented Jan 2, 2017

Thank you for the report! Let us know in case this does not work as intended:

We believe that the bug reported is fixed in the development version. It can be upgraded to it using the self-update command with the --unstable switch.

@tkn98 tkn98 closed this Jan 2, 2017

@tkn98 tkn98 added bug and removed enhancement labels Jan 2, 2017

cmuench added a commit to cmuench/n98-magerun2 that referenced this issue Oct 11, 2017

Dispatch adminhtml_cache_flush_all with cache:flush, closes #263
Thanks to Viktor Steinwand for reporting the missing event dispatch.

Refs:

- #263

- Command: cache:flush
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment