New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow -1 as value for infinite max nesting level for xdebug #278

Merged
merged 2 commits into from Mar 17, 2017

Conversation

Projects
None yet
3 participants
@peterjaap
Contributor

peterjaap commented Mar 16, 2017

Magerun pull-request check-list:

  • Pull request against develop branch (if not, just close and create a new one against it)
  • README.md reflects changes (if any)

Subject: (50 characters or less)

Magerun now gives an error when xdebug.max_nesting_level is set to -1, which is a valid value meaning "no maximum".

$ n98-magerun2.phar install

  Magento 2 Installation

  [RuntimeException]
  Please change PHP ini setting "xdebug.max_nesting_level". Please change it to a value >= 200. Your current value is -1

DavidLambauer and others added some commits Mar 4, 2017

Added Link to the Website and a Status Badge
You can't always have enough badges. To do that, I added a Badge for the Website and updated the introduction. I think it would be great to have a link to the website of magerun because there are also several information a user might want to know.

@cmuench cmuench merged commit 123d58b into netz98:develop Mar 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cmuench

This comment has been minimized.

Show comment
Hide comment
@cmuench

cmuench Mar 17, 2017

Member

Thx

Member

cmuench commented Mar 17, 2017

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment