Strip Admin Users In Development DB Dump#309
Merged
Merged
Conversation
Member
|
Thanks |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Magerun pull-request check-list:
Subject: Strip Admin Users In Development DB Dump
For security purposes, it's better to strip
admin*andauthorization*when dumping a production database for non-production use. For example, the production database could be restored to staging with production admin user data. The staging environment may not have the same level of security as production (e.g. default admin route, not rate limiting brute force password guessing). An attacker could leverage the staging environment to identify production user credentials and then use them to obtain access to the production system.Changes proposed in this pull request:
admin*andauthorization*are stripped when running a development db dumpIf the maintainers agree with this change, I can additionally issue a pull request to n98-magerun.