Permalink
Browse files

bin/neubotw: Comment LOG.redirect() out and unbreak Win7

Before-release testing caught this case where neubotw.exe fails
because it's not privileged and therefore cannot register its own
event source.  Put it another way, under Win7 you cannot log unless
you manage to create an event source with a privileged process.

The release is due as soon as possible, and I don't want to roll
out a patchy solution (particularly because the Windows environment
is, at least for me, quite unpredictable).  So this patch just
comments LOG.redirect() out.

Thanks to Roberto D'Auria that helped with troubleshooting.
  • Loading branch information...
bassosimone committed Mar 18, 2011
1 parent 6bba3b7 commit 65c5703c4985688d0b9c47e4805e74774a7c5e21
Showing with 8 additions and 1 deletion.
  1. +8 −1 bin/neubotw
View
@@ -45,7 +45,14 @@ from neubot.log import LOG
# error for the default logger. The logs are redirected to the NT
# EventLog handler (Start -> Settings -> Control Panel -> Administrative
# Tools -> Event Viewer).
+# FIXME Apparently under windows 7 you cannot access the system logger
+# if you're unprivileged and you have not registered a logging source
+# for your application. This strikes me as very weird because I would
+# have expected it to work like syslog (tho I should already have learnt
+# that Windows is not as predictable as Unix). Since the release is due
+# as soon as possible, I think it's safer to just disable logging for
+# another cycle. Umpf.
#
-LOG.redirect()
+#LOG.redirect()
main(sys.argv)

0 comments on commit 65c5703

Please sign in to comment.