From 452b654447e0290e9e3e17078695483aff84eb0b Mon Sep 17 00:00:00 2001 From: Benjamin Fineran Date: Tue, 26 Apr 2022 09:30:23 -0400 Subject: [PATCH 1/2] server integration check bug fix need to verify integration is set before calling `integration.lower()` --- src/deepsparse/server/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/deepsparse/server/main.py b/src/deepsparse/server/main.py index fa8896948a..b74ea65ab6 100644 --- a/src/deepsparse/server/main.py +++ b/src/deepsparse/server/main.py @@ -128,7 +128,7 @@ def _add_pipeline_route( ): path = "/predict" - if integration.lower() == "sagemaker": + if integration is not None and integration.lower() == "sagemaker": if num_models > 1: raise ValueError( "Sagemaker inference with deepsparse.server currently supports " From 4ecf52810873035c10e5e6949c3dae23ef59e584 Mon Sep 17 00:00:00 2001 From: Benjamin Date: Thu, 28 Apr 2022 18:21:53 -0400 Subject: [PATCH 2/2] respond to review - click choice --- src/deepsparse/server/main.py | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/deepsparse/server/main.py b/src/deepsparse/server/main.py index b74ea65ab6..e8efead286 100644 --- a/src/deepsparse/server/main.py +++ b/src/deepsparse/server/main.py @@ -58,6 +58,12 @@ supplied. --batch_size INTEGER The batch size to serve the model from model_path with. Ignored if config_file is supplied. + --integration [default|sagemaker] + Name of deployment integration that this + server will be deployed to Currently + supported options are 'default' and + 'sagemaker' for inference deployment with + Amazon Sagemaker --help Show this message and exit. @@ -128,7 +134,7 @@ def _add_pipeline_route( ): path = "/predict" - if integration is not None and integration.lower() == "sagemaker": + if integration.lower() == "sagemaker": if num_models > 1: raise ValueError( "Sagemaker inference with deepsparse.server currently supports " @@ -250,11 +256,11 @@ def server_app_factory(): ) @click.option( "--integration", - type=str, - default=None, + type=click.Choice(["default", "sagemaker"], case_sensitive=False), + default="default", help="Name of deployment integration that this server will be deployed to " - "Currently supported options are None for default inference and 'sagemaker' for " - "inference deployment with AWS Sagemaker", + "Currently supported options are 'default' and 'sagemaker' for " + "inference deployment with Amazon Sagemaker", ) def start_server( host: str,