Channelwise Quantization Tests #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Satrat
commented
May 14, 2024
Satrat
commented
- Update e2e regression tests for channelwise scale and zero-point, added channelwise recipe
- Refactored 1.1b test to run on a nightly cadence, 15M will run on commit
Satrat
requested review from
rahul-tuli,
bfineran,
dsikka,
horheynm and
dbogunowicz
bfineran
previously approved these changes
May 15, 2024
rahul-tuli
previously approved these changes
May 15, 2024
|
LGTM, but the runner is now arguably not running any transformers jobs: Requested labels: k8s-eng-gpu-64G-v100-32G
Job defined at: neuralmagic/sparseml/.github/workflows/test-check.yaml@refs/pull/2283/merge
Waiting for a runner to pick up this job... |
bfineran
previously approved these changes
May 20, 2024
dsikka
reviewed
May 20, 2024
bfineran
previously approved these changes
May 20, 2024
dsikka
previously approved these changes
May 22, 2024
There was a problem hiding this comment.
This looks good and applies the framework correctly
Only suggestion would be organizing test_quantization a little bit so that it's easier to follow (i.e private methods at the top, putting tearDown at the end, if the tests rely on inputs/outputs from a previous test, organized to follow that order and a quick comment/docstring to explain the flow)
bfineran
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.