fix issue #91 based on discussion in the comments. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add some helper functions add test for new way of computing feature importance
fix documentation typos [issue #91]
move `flipWeights` to helperFunctions
falkben
reviewed
Jan 17, 2019
R/FeatureImportance.R
Outdated
| for (t in 1:num.trees) { | ||
| idx.end <- idx.start + num.splits[t] - 1L | ||
| unique.projections[idx.start:idx.end] <- | ||
| lapply(1:num.splits[t], function(nd) forest$trees[[t]]$matAstore[(forest$trees[[t]]$matAindex[nd] + 1L):forest$trees[[t]]$matAindex[nd + 1L]]) |
There was a problem hiding this comment.
Just a style thing, but this piece of code would be far easier to read and maintain if we don't deal with indices and reassigning stuff and just append lists together.
pseudo code:
forest_projection = []
for (t in 1:num.trees){
tree_projection = lapply(whatever)
forest_projection = forest_projection + tree_projection
}Merge RunFeature* into the same file. Update README with correct output names.
falkben
approved these changes
Jan 18, 2019
MrAE
added a commit
that referenced
this pull request
Feb 6, 2019
* Add Zenodo DOI Badge. (#118) [Closes #74] * Add Zenodo DOI Badge. * Fix link [Closes #74] * speed up travis builds (#125) * removed the distribution and sudo entries from travis config - faster? * adding back sduo false and adding cache packages option * small updates to contributing guide (#133) * add example for running styler move contributing to .github folder * ignore the .github path * fix indexing order of operations error [fixes #119]. (#134) * added functionality to change mtry and sparsity in Urerf (#120) * added functionality to change mtry and sparsity in Urerf * ran styler on modified files and removed white space. * added tests for new RandMat functions. * Added the functionality to splitting based on BIC score using Mclust (#124) * added functionality to change mtry and sparsity in Urerf * Added functionality to split based on BIC score * Add LinearCombo arg to the Urerf fn * Add fast version of BIC * fix some minor errors (#141) Ran through styler and fixed some roxygen import and documentation. * fix issue #91 based on discussion in the comments. (#140) * fix issue #91 based on discussion in the comments. add some helper functions add test for new way of computing feature importance * remove need for library(Matrix) and update function parameteres. fix documentation typos [issue #91] * update test-FeatureImportance move `flipWeights` to helperFunctions * update Feature Importance to be more readable [@ben]. Merge RunFeature* into the same file. Update README with correct output names. * check-as-cran warning will now cause TravisCI to fail. (#142) * Print tree (#136) * added functionality to change mtry and sparsity in Urerf * ran styler on modified files and removed white space. * added tests for new RandMat functions. * added PrintTree function and modified NAMESPACE file to call PrintTree (I'm not sure this last step was necessary but it doesn't hurt. * Add documentation and adjust the formatting of the output. * the double comparison now relies on machine epsilon. (#149) * the double comparison now relies on machine epsilon. * fix for test not passing * move an assignment out of an if condition. (#151) Fixes issue #135 * Packed forest submodule (#152) * add packedForest submodule * update submodule to latest commitadd readme for submodule operations * update submodule readme * update submodule * update submodule (#154) * update submodule (#155) * Draft of v2.0.3 for CRAN (#156) * Draft of v2.0.3 for CRAN no warnings, errors, or notes on my Mac. * run README.Rmd * update submodule (#159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add some helper functions
add test for new way of computing feature importance