Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to contributing guide to website #243

Merged
merged 12 commits into from Jul 25, 2019
Merged

Add to contributing guide to website #243

merged 12 commits into from Jul 25, 2019

Conversation

@j1c
Copy link
Member

j1c commented Jul 25, 2019

Add contributing guide to the website.

#240

@netlify

This comment has been minimized.

Copy link

netlify bot commented Jul 25, 2019

Deploy preview for graspy ready!

Built with commit 6e6f99d

https://deploy-preview-243--graspy.netlify.com

@j1c j1c changed the title Add to website Add to contributing guide to website Jul 25, 2019
j1c added 5 commits Jul 25, 2019
@j1c j1c requested a review from bdpedigo Jul 25, 2019
j1c added 2 commits Jul 25, 2019
@bdpedigo

This comment has been minimized.

Copy link
Collaborator

bdpedigo commented Jul 25, 2019

Looks good, only other thought is whether it's worth having a stub like this https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md still in the github, just because that's often how developers will be viewing the project

@bdpedigo

This comment has been minimized.

Copy link
Collaborator

bdpedigo commented Jul 25, 2019

In fact maybe we should just steal that

@j1c

This comment has been minimized.

Copy link
Member Author

j1c commented Jul 25, 2019

Added

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 25, 2019

Codecov Report

Merging #243 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files          33       33           
  Lines        1935     1935           
=======================================
  Hits         1667     1667           
  Misses        268      268

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 687daab...6e6f99d. Read the comment docs.

@j1c j1c merged commit 80d6431 into master Jul 25, 2019
7 checks passed
7 checks passed
Header rules - graspy No header rules processed
Details
Pages changed - graspy 11 new files uploaded
Details
Redirect rules - graspy No redirect rules processed
Details
Mixed content - graspy No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
netlify/graspy/deploy-preview Deploy preview ready!
Details
@j1c j1c deleted the contrib branch Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.