New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements #399

Open

1 of 2 tasks

j1c opened this issue Sep 30, 2020 · 0 comments

Member

j1c commented Sep 30, 2020 •

edited by Lawreros

This is a list of things that can be changed to substantially improve performance of m2g. Some of it is addressed in #398

Im 1000% percent sure below line is tabbed incorrectly. It should be outside the for loop.

m2g/m2g/graph.py

Line 216 in be29587

self.g.add_weighted_edges_from(edge_list)

with ~1 million streamlines, it takes ~35 minutes vs 2 minutes with the line outside the for loop.

There is a parallel version in my PR.

I think the streamline generation can be parallelized by sending partial seed list to bunch of Track instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment