Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on tutorial section from Fall school #116

Closed
timonmerk opened this issue Nov 2, 2021 · 1 comment
Closed

Work on tutorial section from Fall school #116

timonmerk opened this issue Nov 2, 2021 · 1 comment
Assignees
Labels
wontfix This will not be worked on

Comments

@timonmerk
Copy link
Contributor

I pulled the last version of the py_neuromodulation git repo. I followed the clear instructions on setting up the environment. I tried
conda env create --file=env.yml --user
but the --user handle was unknown and I had to remove it. Maybe it was probably a noob problem requiring further input or specification what the user is for, from my side but I guess there are more and more noobs starting to switch from Matlab to Python so it may be good to explain or double check this is correct.

I suppose binder would circumvent this problem, but I only found the binder button after a long search. I would suggest mentioning the binder and what it can do explicitly in the readme and definitely add the link to both repo and binder to the presentation.

The main problem I found was the question on how to start the hands-on part. So I checked the repo and started working on the Fall school Notebook_1_Tasks.ipynb and found a few minor bugs (e.g. Y instead of y that is expected further on etc.). Then I checked the Fall school Notebook_2_Tasks.ipynb thinking that would be the more recent or correct version, but this already included solutions so I opened Fall school Notebook_3 which also included solutions but was slightly different to notebooks 1 and 2. I am sure you kept improving everything, so this is clearly just a minor thing, but before times passes by and we don't remember anymore, I would suggest to create one clean version called *_tasks.ipynb & _solutions.ipynb .

Would it be possible to move these notebooks out of the main repo into a tutorial folder?

I found the tasks to be more python coding related than machine learning related. They were great for me but may not be what people are expecting. Potential ML related tasks could be to repeat the cross-validation or chose different feature sets and explore the effects. If you want, we could take some time next week and go through them again and adapt a little?

@timonmerk timonmerk self-assigned this Nov 2, 2021
@timonmerk
Copy link
Contributor Author

timonmerk commented Nov 19, 2021

  • Merge part 1 & 2
  • Include command running py_neuro for example data

@timonmerk timonmerk added the wontfix This will not be worked on label Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant