Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
make init-common.sh compatible with docker build #71
To allow running the
Setting the environment variable
To see this in action please have a look at the docker image at arose/qtrpi.
Btw: great work on this project so far!
Thanks a lot for your contribution, Docker makes perfect sense. There's a couple of things I'd like to discuss before integrating this patch:
thanks for your feedback! I made the requested changes so far.
I don't think it makes sense to put one single Dockerfile in the project root, since the configuration has to be hardcoded into the Dockerfile to allow convenient usage.
If it is to be done "right", I'd suggest providing a dockerfile for each possible combination between hardware and software and have them autobuild on docker hub. This way people could make use of the project by simply pulling and running the respective container.
Currently I have made 2 Dockerfiles for the Raspi 3 and Qt 5.6 or 5.7 at https://github.com/rose-a/qtrpi-docker-image, which are automatically build on Docker Hub. I am still working on shrinking the images, since they are currently 4.8 GB in size.
I'll integrate them into the repository as a start if you like.