-
Notifications
You must be signed in to change notification settings - Fork 312
blocks browser when no tasks given (empty array) #86
Comments
@DanielRuf @neuronetio |
I figured this out. Check the code below. gantt-elastic/src/GanttElastic.vue Lines 1326 to 1352 in e93210e
If no tasks given, the firstTaskTime will be Number.MAX_SAFE_INTEGER and the lastTaskTime will be 0. They are both invalid time ms. We can set reasonable values to them when no tasks given. Fix could like below (set the default time range from today to 7 days later ):
@neuronetio I will give a PR later. Could you please help reviewing it? Thanks! |
Here is the pr: #101 |
My gantt is working now. Nice! thanks |
Describe the bug
When we provide an empty array for the tasks the browser is loading forever but does not respond / hangs.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It should not hang when an empty tasks array is used.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
VueJS
The text was updated successfully, but these errors were encountered: