From b3bda58f20241cc6b210d73eb06625e66f90d627 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alexandru=20S=C4=83vulescu?= <alexandru.savulescu@epfl.ch>
Date: Tue, 13 Sep 2022 09:56:52 +0200
Subject: [PATCH] curate 136803 & update PR CI selection of models (#52)

* curate 136803
   * model_dir: mod_files
* update PR selection of models
* add description of model selection for PRs
---
 .github/workflows/nrn-modeldb-ci.yaml | 15 +++++++++++++--
 modeldb/modeldb-run.yaml              |  5 +++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/nrn-modeldb-ci.yaml b/.github/workflows/nrn-modeldb-ci.yaml
index 08030d8..48ab0dd 100644
--- a/.github/workflows/nrn-modeldb-ci.yaml
+++ b/.github/workflows/nrn-modeldb-ci.yaml
@@ -79,8 +79,19 @@ jobs:
 
     - name: Set models to run for PR
       run: |
-        # Select a few models to run CI for PRs 
-        echo 'MODELS_TO_RUN=279 3264 22203 144549 105507 194897' >> $GITHUB_ENV
+        # For PRs we only have a few models for quick sanity checking.
+        # Once the PR is green you need to manually run the ModelDB CI workflow by simply selecting your branch in the UI.
+
+        # The follwing selection aims to target different features (since we haven't worked on unit testing yet -> #38 ).
+        # Select a few models to run CI for PRs:
+        #   64195   -> run: null
+        #   22203   -> skip: true
+        #   156120  -> several model directories
+        #   97868   -> failed nrnivmodl
+        #   146030  -> curate_patterns
+        #   244679  -> no entry in modeldb-run.yaml
+        #   rest:   -> currently yielding differences in the pipeline
+        echo 'MODELS_TO_RUN=64195 22203 156120 51781 97868 22203 97756 97917 105507 136803 138379 138382 146030 244679 251881' >> $GITHUB_ENV
       if: github.event_name == 'pull_request'
 
     - name: Install dependencies and project
diff --git a/modeldb/modeldb-run.yaml b/modeldb/modeldb-run.yaml
index 8b24843..8302bf6 100644
--- a/modeldb/modeldb-run.yaml
+++ b/modeldb/modeldb-run.yaml
@@ -1102,6 +1102,11 @@
     - verify_graph_()
     script:
     - sed -i'.bak' -e 's/tstop = 550/tstop = 100/' HAM_SR1.ses
+136803:
+    run:
+    - run()
+    - verify_graph_()
+    model_dir: mod_files
 # python models
 189922:
     python: true