Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AxonDeepSeg/models directory and update .gitignore #476

Merged
merged 5 commits into from Mar 22, 2021

Conversation

vasudev-sharma
Copy link
Contributor

@vasudev-sharma vasudev-sharma commented Mar 17, 2021

Checklist

  • I've given this PR a concise, self-descriptive, and meaningful title
  • I've linked relevant issues in the PR body
  • I've applied the relevant labels to this PR
  • I've added relevant tests for my contribution
  • I've updated the documentation and/or added correct docstrings
  • I've assigned a reviewer
  • I've consulted ADS's internal developer documentation to ensure my contribution is in line with any relevant design decisions

Description

The aim of the PR is to keep the AxonDeepSeg/models directory only for storing the models as discussed in the last meeting; we don't want to keep scripts under the models directory. The download_model.py script has been moved to AxonDeepSeg directory.

This will not only keep the codebase clean but also we needn't update the .gitignore file each time a new model is added under the AxonDeepSeg/models directory.

Linked issues

I didn't create an issue for this PR because it was already decided in the last meeting and refactoring task was trivial, so thought of submitting a PR instead.

@vasudev-sharma vasudev-sharma added models context refactoring context: code refactoring labels Mar 17, 2021
Copy link
Member

@mariehbourget mariehbourget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mathieuboudreau mathieuboudreau merged commit 133912c into master Mar 22, 2021
@mathieuboudreau mathieuboudreau deleted the vs/refactor_models_directory branch March 22, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models context refactoring context: code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants