Fixed ignored -init flag and minor improvements #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because (i) it was saved as centerline.nii.gz and could interact with user's other data and (ii) there is another centerline output, called input_centerline.nii.gz and derived from the segmentation directly, which is more precise, so there is no point of having two output centerlines which are different.
jcohenadad
changed the title
jcohenadad
pushed a commit
that referenced
this pull request
Dec 18, 2019
Fixed ignored -init flag and minor improvements Former-commit-id: a91890e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a regression bug,
v4.0.0-beta.1was not accounting for the flag-initanymore. This PR addresses that issue, as well as other minor improvements:-initflag ignored in v4.0.0-beta.1. Fixes -init flag ignored in v4.0.0-beta.1 #2190xxx_centerline.nii.gzand directly derived from the segmentation directly (hence more precise).