Fixed problem with parameters xmax, ymax and zmax #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnBucquet
added
bug
jcohenadad
changed the title
jcohenadad
reviewed
Feb 19, 2020
spinalcordtoolbox/cropping.py
Outdated
| @@ -38,9 +38,9 @@ def _get_max_value(input, dim): | |||
| # If empty, return dim+1 (corresponds to the maximum of the given dimension, e.g. nx) | |||
| if input is None: | |||
| return dim + 1 | |||
There was a problem hiding this comment.
to be consistent, this should be dim (not dim+1), right?
There was a problem hiding this comment.
Yes, you're right! Thx
jcohenadad
reviewed
Feb 19, 2020
spinalcordtoolbox/cropping.py
Outdated
| @@ -38,9 +38,9 @@ def _get_max_value(input, dim): | |||
| # If empty, return dim+1 (corresponds to the maximum of the given dimension, e.g. nx) | |||
| if input is None: | |||
| return dim + 1 | |||
| # If negative sign, return dim+1 if -1, dim if -2, dim-1 if -3, etc. | |||
| # If negative sign, return dim if -1, dim-1 if -2, dim-2 if -3, etc. | |||
There was a problem hiding this comment.
To clarify (the comment is in contradiction with the code), i would write:
# If input is "-1", return maximum dimension (i.e. no change). If input is "-2", returns maximum dimension minus one, etc.
jcohenadad
requested changes
Feb 19, 2020
There was a problem hiding this comment.
Thanks @AnBucquet-- i would also clarify the usage:
-xmin <int> Lower bound for cropping along X.
-xmax <int> Higher bound for cropping along X. Setting '-1' will crop to the maximum dimension (i.e. no change), '-2' will crop to the maximum dimension minus 1 slice, etc.
-ymin <int> Lower bound for cropping along Y.
-ymax <int> Higher bound for cropping along Y. Follows the same rules as xmax.
-zmin <int> Lower bound for cropping along Z. Follows the same rules as xmax.
-zmax <int> Higher bound for cropping along Z. Follows the same rules as xmax.
|
It should be good now. Thx for the review! Let me know if you find anything else. |
|
Need to change |
jcohenadad
reviewed
Feb 19, 2020
| help="Higher bound for cropping along X. Setting '-1' will crop to the maximum dimension, '-2' will crop to " | ||
| "the maximum dimension minus 1 slice, etc.", | ||
| help="Higher bound for cropping along X. Setting '-1' will crop to the maximum dimension (i.e. no change), " | ||
| "'-2' will crop to the maximum dimension minus 1 slice, etc.", |
There was a problem hiding this comment.
zmin should be: "Lower bound for cropping along Z.",
zmax should be: "Higher bound for cropping along Z. Follows the same rules as xmax."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just removed the
+1in that line to get the correct dimension.Fixes #2603