Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest: Set testEnvironment to 'node' when targeting node #1030

Merged
merged 1 commit into from Aug 21, 2018

Conversation

@edmorley
Copy link
Member

edmorley commented Aug 21, 2018

Since the testEnvironment default of 'jsdom' is only suitable when testing code intended to run in a browser environment. See:
https://jestjs.io/docs/en/configuration.html#testenvironment-string

Fixes #1020.

Since the `testEnvironment` default of `'jsdom'` is only suitable
when testing code intended to run in a browser environment. See:
https://jestjs.io/docs/en/configuration.html#testenvironment-string

Fixes #1020.
@edmorley edmorley added this to the v9 milestone Aug 21, 2018
@edmorley edmorley self-assigned this Aug 21, 2018
@edmorley edmorley requested a review from eliperelman Aug 21, 2018
Copy link
Member

eliperelman left a comment

💯

@eliperelman eliperelman merged commit 6a0609d into neutrinojs:master Aug 21, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@edmorley edmorley deleted the edmorley:jest-testEnvironment-node branch Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.