Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Jest: Set testEnvironment to 'node' when targeting node #1030

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Jest: Set testEnvironment to 'node' when targeting node #1030

merged 1 commit into from
Aug 21, 2018

Conversation

edmorley
Copy link
Member

Since the testEnvironment default of 'jsdom' is only suitable when testing code intended to run in a browser environment. See:
https://jestjs.io/docs/en/configuration.html#testenvironment-string

Fixes #1020.

Since the `testEnvironment` default of `'jsdom'` is only suitable
when testing code intended to run in a browser environment. See:
https://jestjs.io/docs/en/configuration.html#testenvironment-string

Fixes #1020.
@edmorley edmorley added this to the v9 milestone Aug 21, 2018
@edmorley edmorley self-assigned this Aug 21, 2018
Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@eliperelman eliperelman merged commit 6a0609d into neutrinojs:master Aug 21, 2018
@edmorley edmorley deleted the jest-testEnvironment-node branch August 28, 2018 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants