Specify root option for monorepo scripts and project creation #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this is similar to the other PR, but I did have an extra change I wanted to check. |
edmorley
approved these changes
Aug 24, 2018
I think we also need to set root for the webpack.config.js, jest.config.js, mocha.config.js and karma.conf.js templates too. Thoughts?
(Happy for that to be in this PR or a new one)
.eslintrc.js
Outdated
| @@ -1,3 +1,8 @@ | |||
| const neutrino = require('./packages/neutrino'); | |||
|
|
|||
| module.exports = neutrino(require('./.neutrinorc')).eslintrc(); | |||
| module.exports = neutrino({ | |||
| use: require('./.neutrinorc'), // eslint-disable-line global-require | |||
There was a problem hiding this comment.
Perhaps we should move the require() to the top of the file and save needing the eslint-disable-line? (in this file and the others)
|
(Sorry I'd missed the re-review request email notification) |
eliperelman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #973.
I'm not sure how this wasn't happening before, but when running without the
--no-eslintrcbits in the precommit I would get errors around eslint being unable to load the config file. I think this was related to eslint trying to load these nested eslintrc files to lint their subdirectories, which we definitely don't want during development.So now I added
--no-eslintrc -c ./.eslintrc.jsso it will lint the monorepo using only our top-level eslintrc. When you run it like this though, eslint gives you warnings that the create-project eslintrc files are ignored by default, so the eslintignore line addition is to add these back to being linted, but not used as config.