Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stylelint middleware #1110

Merged
merged 3 commits into from Sep 20, 2018
Merged

Conversation

@eliperelman
Copy link
Member

eliperelman commented Sep 19, 2018

Closes #805.
Closes #982.

We cannot seem to get a recent release of stylelint-webpack-plugin [1] in order to provide any value.

[1] webpack-contrib/stylelint-webpack-plugin#149

@eliperelman eliperelman added this to the v9 milestone Sep 19, 2018
@eliperelman eliperelman self-assigned this Sep 19, 2018
@eliperelman eliperelman requested a review from edmorley Sep 19, 2018
@eliperelman eliperelman force-pushed the eliperelman:remove-stylelint branch from 05cb21a to 69ac8f5 Sep 19, 2018
@edmorley

This comment has been minimized.

Copy link
Member

edmorley commented Sep 19, 2018

To add some additional reasons from IRC:

  1. unlike the eslint related presets in this repository, the @neutrinojs/stylelint preset doesn't actually have much to configure, and doesn't really change it's behaviour based on other presets (compared to say the interactions between the JS linting presets when using the react/preact/vue/node presets). As such it doesn't save much work over people just adding stylelint-webpack-plugin directly in their .neutrinorc.js.
  2. for CSS I don't think there's as much value for "linting during the build", compared to JS. For example, one advantage of eslint-loader is that it can give a useful linting error that might prevent/explain a runtime exception that would otherwise mean opening the browser console and figuring out why the app broke. That kind of scenario is much less likely to occur with CSS. As such a yarn lint:style that runs the styelint CLI outside of the webpack build, or an editor/IDE plugin would likely be sufficient for many cases.
  3. Given (2), one option would be for us to ditch the stylelint-webpack-plugin part of @neutrinojs/stylelint and just keep the neutrino().stylelintrc() config generation for use with the stylelint CLI. However given (1), it doesn't seem like that adds any value over people just using a static config in .stylelintrc.js and not using Neutrino for it at all.
@eliperelman eliperelman force-pushed the eliperelman:remove-stylelint branch from 69ac8f5 to 29881a0 Sep 20, 2018
@eliperelman eliperelman merged commit c911a21 into neutrinojs:master Sep 20, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deploy/netlify Deploy preview processing.
Details
@timkelty

This comment has been minimized.

Copy link
Contributor

timkelty commented Sep 26, 2018

@edmorley @eliperelman late response again guys, but I totally agree. Trim the fat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.