Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upOutput generated files under an assets/ subdirectory #1174
Merged
Conversation
edmorley
changed the title
This makes it easier to write `Cache-Control` header rules for files with hashed filenames, since the web server rule can now just match the entire `assets/` directory rather than having to use false-positive prone regex to match the hash in the filename. In addition, this PR removes some redundant configuration: * The `@neutrinojs/node` and `@neutrinojs/library` presets no longer set `output.filename` / `output.chunkFilename`, since they were previously only being set to the defaults anyway. * The `@neutrinojs/web` preset no longer sets `output.chunkFilename` since by default it inherits from `output.filename`, so setting both to the same value is redundant: https://github.com/webpack/webpack/blob/v4.20.2/lib/WebpackOptionsDefaulter.js#L102-L112 Fixes #1172.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
edmorley commentedOct 13, 2018
•
edited
This makes it easier to write
Cache-Controlheader rules for files with hashed filenames, since the web server rule can now just match the entireassets/directory rather than having to use false-positive prone regex to match the hash in the filename.In addition, this PR removes some redundant configuration:
@neutrinojs/nodeand@neutrinojs/librarypresets no longer setoutput.filename/output.chunkFilename, since they were previously only being set to the defaults anyway.@neutrinojs/webpreset no longer setsoutput.chunkFilenamesince by default it inherits fromoutput.filename, so setting both to the same value is redundant:https://github.com/webpack/webpack/blob/v4.20.2/lib/WebpackOptionsDefaulter.js#L102-L112
Fixes #1172.