Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Default output.publicPath to '/' #1185

Merged
merged 1 commit into from Oct 23, 2018
Merged

web: Default output.publicPath to '/' #1185

merged 1 commit into from Oct 23, 2018

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Oct 22, 2018

Since otherwise apps that use the HTML 5 pushState history API won't work when deployed, even with the necessary server rewrite rules configured.

Apps that are deployed from a non-domain-root location (such as those hosted on GitHub pages) will now need to explicitly set publicPath themselves, however this is the case with CRA and vue-cli too.

Fixes #1171.

@edmorley edmorley added this to the v9 milestone Oct 22, 2018
@edmorley edmorley self-assigned this Oct 22, 2018
Since otherwise apps that use the HTML 5 pushState history API won't
work when deployed, even with the necessary server rewrite rules
configured.

Apps that are deployed from a non-domain-root location (such as those
hosted on GitHub pages) will now need to explicitly set `publicPath`
themselves, however this is the case with CRA and vue-cli too.

Fixes #1171.
@edmorley edmorley requested review from eliperelman and timkelty Oct 22, 2018
Copy link
Contributor

@timkelty timkelty left a comment

Looks great!

@edmorley edmorley merged commit 1c082ac into neutrinojs:master Oct 23, 2018
2 checks passed
@edmorley edmorley deleted the root-publicPath branch Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants