Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

eslint: Downgrade linter errors to warnings in development #1216

Merged
merged 1 commit into from Nov 20, 2018
Merged

eslint: Downgrade linter errors to warnings in development #1216

merged 1 commit into from Nov 20, 2018

Conversation

edmorley
Copy link
Member

To reduce the noise in the webpack-dev-server overlay (which defaults to showing errors only and is going to be enabled soon in #1131), and to also ensure hot reloading isn't prevented.

See:
https://github.com/webpack-contrib/eslint-loader#options

To reduce the noise in the webpack-dev-server overlay (which defaults
to showing errors only and is going to be enabled soon in #1131),
and to also ensure hot reloading isn't prevented.

See:
https://github.com/webpack-contrib/eslint-loader#options
@edmorley edmorley merged commit e9c73a6 into neutrinojs:master Nov 20, 2018
@edmorley edmorley deleted the eslint-emitWarning branch November 20, 2018 16:40
edmorley added a commit that referenced this pull request Nov 20, 2018
See:
https://webpack.js.org/configuration/dev-server/#devserver-overlay

Note this change 'relies' on #1216, in that without that change all
linter errors would be displayed in the overlay too, which is likely
too noisy (given that many rules are for stylistic issues that should
not block viewing the dev-server page output).

Fixes #1131.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants