Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile-loader: Remove babel-merge export #1220

Merged
merged 1 commit into from Nov 26, 2018
Merged

compile-loader: Remove babel-merge export #1220

merged 1 commit into from Nov 26, 2018

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Nov 23, 2018

Since it's no longer a custom implementation and instead just the babel-merge package exported. As such it makes more sense for packages to import babel-merge directly iff they need it.

This also avoids the naming clash between merge from this preset and the typical import style used for deepmerge in this repository, that contributed to the bug fixed by #1219.

@edmorley edmorley added this to the v9 milestone Nov 23, 2018
@edmorley edmorley self-assigned this Nov 23, 2018
@edmorley edmorley requested a review from eliperelman Nov 23, 2018
Since it's no longer a custom implementation and instead just the
`babel-merge` package exported. As such it makes more sense for
packages to import `babel-merge` directly iff they need it.

This also avoids the naming clash between `merge` from this preset
and the typical import style used for `deepmerge` in this repository,
that contributed to the bug fixed by #1219.
@edmorley edmorley merged commit e9c21b8 into neutrinojs:master Nov 26, 2018
6 checks passed
@edmorley edmorley deleted the rm-compile-loader-merge branch Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants