This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Move style extraction conditionals from web into style-loader #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
changed the title
Previously the `NODE_ENV` check for determining whether to enable stylesheet extraction existed only in `@neutrinojs/web`, meaning that if `@neutrinojs/style-loader` was manually used (either on its own or in coordination with the web preset), then extraction would be incorrectly enabled in development. The `style.extract = false` shorthand of always disabling extraction still works, however `style.extract = true` must now be replaced by `style.extract.enabled = true` (though I believe that style is not likely to have been used by many projects, since it's more common to want to disable in production than enable in development).
edmorley
commented
Nov 23, 2018
| @@ -36,10 +36,7 @@ module.exports = (neutrino, opts = {}) => { | |||
| devServer: { | |||
| hot: opts.hot !== false | |||
| }, | |||
| style: { | |||
| hot: opts.hot !== false, | |||
There was a problem hiding this comment.
This hot option is unused as of:
https://github.com/neutrinojs/neutrino/pull/809/files#diff-02ca3d58d2c51d575c7a93b33b0afcfdL16
eliperelman
approved these changes
Nov 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
NODE_ENVcheck for determining whether to enable stylesheet extraction existed only in@neutrinojs/web, meaning that if@neutrinojs/style-loaderwas manually used (either on its own or in coordination with the web preset), then extraction would be incorrectly enabled in development.The
style.extract = falseshorthand of always disabling extraction still works, howeverstyle.extract = truemust now be replaced bystyle.extract.enabled = true(though I believe that style is not likely to have been used by many projects, since it's more common to want to disable in production than enable in development).